Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community grants section #25

Merged
merged 11 commits into from
Feb 21, 2024
Merged

Community grants section #25

merged 11 commits into from
Feb 21, 2024

Conversation

technophile-04
Copy link
Member

Description

Lol had to play around with background image height but it kinda works on mobile too, we can play more with heights if it doesn't good look 🙌
Demo :

Screen.Recording.2024-02-20.at.6.51.10.PM.mov

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
grants-bg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 6:14am

Copy link
Contributor

@carletex carletex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing Shiv!!! <333

Pushed some tweaks to the copy (and some tiny tweaks on spacing).

A couple of things:

  1. Could you make the "learn more" button from the hero to go to this section?
  2. Could you change the orange patch to this?
    orange-patch

If not, it cuts off on mobile. On desktop, you might need to move the image down and "hide the overflow" in the section.

@technophile-04
Copy link
Member Author

Could you change the orange patch to this?

if not, it cuts off on mobile. On desktop, you might need to move the image down and "hide the overflow" in the section.

Tysm for the image !! Updated at f8a4a8c, could you check once 🙌

Could you make the "learn more" button from the hero to go to this section?

Ohh missed it ! Updated at 6fab426

Copy link
Member

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting to get familiar with the repo, just added a small nitpick, feel free to ignore if you see it better like it is now🙌

packages/nextjs/app/_components/CommunityGrant.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@carletex carletex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amaziiiing!!

@carletex carletex merged commit 79094d9 into main Feb 21, 2024
3 checks passed
@carletex carletex mentioned this pull request Feb 21, 2024
@carletex carletex deleted the community-grants-section branch March 6, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants